use metadata classes for cell and notebook document implementation, https://github.com/microsoft/vscode/issues/116333

This commit is contained in:
Johannes Rieken
2021-02-15 16:54:24 +01:00
parent f2a491fbc8
commit 5f48de03e6
3 changed files with 47 additions and 27 deletions

View File

@@ -729,7 +729,7 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN
emitDocumentMetadataChange(event: vscode.NotebookDocumentMetadataChangeEvent): void {
that._onDidChangeNotebookDocumentMetadata.fire(event);
}
}, viewType, modelData.contentOptions, { ...notebookDocumentMetadataDefaults, ...modelData.metadata }, uri, storageRoot);
}, viewType, modelData.contentOptions, typeConverters.NotebookDocumentMetadata.to(modelData.metadata ?? {}), uri, storageRoot);
document.acceptModelChanged({
versionId: modelData.versionId,