From e1425022964548f5e04504c2bae62937e392d4e3 Mon Sep 17 00:00:00 2001 From: Henning Dieterichs Date: Thu, 30 Jun 2022 16:23:01 +0200 Subject: [PATCH 1/2] Makes "Remaining Conflicts" localizable. --- .../browser/view/editors/resultCodeEditorView.ts | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/contrib/mergeEditor/browser/view/editors/resultCodeEditorView.ts b/src/vs/workbench/contrib/mergeEditor/browser/view/editors/resultCodeEditorView.ts index 1bdd79fb0e1d..fc6919af08ac 100644 --- a/src/vs/workbench/contrib/mergeEditor/browser/view/editors/resultCodeEditorView.ts +++ b/src/vs/workbench/contrib/mergeEditor/browser/view/editors/resultCodeEditorView.ts @@ -5,6 +5,7 @@ import { CompareResult } from 'vs/base/common/arrays'; import { IModelDeltaDecoration, MinimapPosition, OverviewRulerLane } from 'vs/editor/common/model'; +import { localize } from 'vs/nls'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { autorun, derivedObservable } from 'vs/workbench/contrib/audioCues/browser/observable'; import { LineRange } from 'vs/workbench/contrib/mergeEditor/browser/model/lineRange'; @@ -113,8 +114,17 @@ export class ResultCodeEditorView extends CodeEditorView { } const count = model.unhandledConflictsCount.read(reader); - // TODO @joh - this._detail.setLabel(`${count} Remaining Conflicts`); + this._detail.setLabel(count === 1 + ? localize( + 'mergeEditor.remainingConflicts', + '{0} Remaining Conflict', + count + ) + : localize( + 'mergeEditor.remainingConflict', + '{0} Remaining Conflicts', + count + )); }, 'update label')); } } From 1c793dfac8b6da321ffd498a530332ebe3b740b8 Mon Sep 17 00:00:00 2001 From: Henning Dieterichs Date: Thu, 30 Jun 2022 16:24:02 +0200 Subject: [PATCH 2/2] Adds menu separator. --- .../mergeEditor/browser/view/editors/inputCodeEditorView.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/mergeEditor/browser/view/editors/inputCodeEditorView.ts b/src/vs/workbench/contrib/mergeEditor/browser/view/editors/inputCodeEditorView.ts index 74452e55aeb3..e65d5c9c8ef1 100644 --- a/src/vs/workbench/contrib/mergeEditor/browser/view/editors/inputCodeEditorView.ts +++ b/src/vs/workbench/contrib/mergeEditor/browser/view/editors/inputCodeEditorView.ts @@ -5,7 +5,7 @@ import * as dom from 'vs/base/browser/dom'; import { Toggle } from 'vs/base/browser/ui/toggle/toggle'; -import { Action, IAction } from 'vs/base/common/actions'; +import { Action, IAction, Separator } from 'vs/base/common/actions'; import { Codicon } from 'vs/base/common/codicons'; import { Disposable } from 'vs/base/common/lifecycle'; import { noBreakWhitespace } from 'vs/base/common/strings'; @@ -185,6 +185,7 @@ export class InputCodeEditorView extends CodeEditorView { { enabled: baseRange.canBeCombined } ) : undefined, + new Separator(), baseRange.isConflicting ? setFields( action(