Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-29 21:11:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix TS 2.3.1 Compiler Errors in VSCode src/workbench (#25249)

Browse Source 
TS 2.3.1 introduced a breaking change by [switching to covariant types for callbacks](https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#covariance-in-callback-parameters). This change tries to fix these compiler errors in the workbench codebase
This commit is contained in:
Matt Bierner
2017-04-25 08:20:25 -07:00
committed by GitHub
parent 2868ee6ef8
commit 6147b54439
37 changed files with 105 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/vs/workbench/api/node/extHostTextEditor.ts
View File

@@ -513,7 +513,7 @@ export class ExtHostTextEditor implements vscode.TextEditor {
private _runOnProxy(callback: () => TPromise<any>, silent: boolean): TPromise<ExtHostTextEditor> {
if (this._disposed) {
if (!silent) {
return TPromise.wrapError(silent);
return TPromise.wrapError<ExtHostTextEditor>(silent);
} else {
console.warn('TextEditor is closed/disposed');
return TPromise.as(undefined);
@@ -521,7 +521,7 @@ export class ExtHostTextEditor implements vscode.TextEditor {
}
return callback().then(() => this, err => {
if (!silent) {
return TPromise.wrapError(silent);
return TPromise.wrapError<ExtHostTextEditor>(silent);
}
console.warn(err);
return undefined;