Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-24 12:19:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make it clearer that insert text snippets override the rest snippet generation

Browse Source
This commit is contained in:
Matt Bierner
2018-11-20 17:18:26 -08:00
parent d5843e550f
commit 61ad185759
1 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
extensions/typescript-language-features/src/features/completions.ts
View File

@@ -628,20 +628,14 @@ export function snippetForFunctionCall(
item: { insertText?: string | vscode.SnippetString, label: string },
displayParts: ReadonlyArray<Proto.SymbolDisplayPart>
): vscode.SnippetString {
if (item.insertText && typeof item.insertText !== 'string') {
return item.insertText;
}
let hasOptionalParameters = false;
let hasAddedParameters = false;
const snippet = new vscode.SnippetString();
if (item.insertText) {
if (typeof item.insertText === 'string') {
snippet.appendText(item.insertText);
} else {
return item.insertText;
}
} else {
snippet.appendText(item.label);
}
snippet.appendText('(');
const snippet = new vscode.SnippetString(`${item.insertText || item.label}(`);
const functionSignatureDisplayParts = getFunctionSignatureDisplayParts(displayParts, item.label);
let parenCount = 0;