Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-26 11:38:51 +01:00
Code Issues Packages Projects Releases Wiki Activity

#19685 Revert changes in Extension Description

Browse Source 
- Revert changes to id in Ext description. No lowering of name.
- Implement an equal function to check equality of extensions
- Use above function to check the equality with extension description
This commit is contained in:
Sandeep Somavarapu
2017-03-03 11:24:40 +01:00
parent 77d7e0b0d3
commit 622b8004f4
7 changed files with 17 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/vs/workbench/node/extensionPoints.ts
View File

@@ -17,7 +17,7 @@ import json = require('vs/base/common/json');
import Types = require('vs/base/common/types');
import { isValidExtensionDescription } from 'vs/platform/extensions/node/extensionValidator';
import * as semver from 'semver';
import { getIdAndVersionFromLocalExtensionId, getGalleryExtensionId } from 'vs/platform/extensionManagement/common/extensionManagementUtil';
import { getIdAndVersionFromLocalExtensionId } from 'vs/platform/extensionManagement/common/extensionManagementUtil';
const MANIFEST_FILE = 'package.json';
@@ -237,7 +237,7 @@ class ExtensionManifestValidator extends ExtensionManifestHandler {
});
// id := `publisher.name`
extensionDescription.id = getGalleryExtensionId(extensionDescription.publisher, extensionDescription.name);
extensionDescription.id = `${extensionDescription.publisher}.${extensionDescription.name}`;
// main := absolutePath(`main`)
if (extensionDescription.main) {