Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-26 19:44:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Take kind instead of edit in CodeAction ctor

Browse Source 
Changes the `CodeAction` constructor to take a kind instead of an edit. This makes the API more consistent IMO, as now both `edit` and `command` are set the same way
This commit is contained in:
Matt Bierner
2018-01-22 11:59:17 -08:00
parent 3cb83387be
commit 6316a4d0c8
5 changed files with 26 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/vs/workbench/api/node/extHostApiCommands.ts
View File

@@ -417,10 +417,10 @@ export class ExtHostApiCommands {
} else {
const ret = new types.CodeAction(
codeAction.title,
typeConverters.WorkspaceEdit.to(codeAction.edit)
codeAction.kind ? new types.CodeActionKind(codeAction.kind) : undefined
);
if (codeAction.kind) {
ret.scope = new types.CodeActionKind(codeAction.kind);
if (codeAction.edit) {
ret.edit = typeConverters.WorkspaceEdit.to(codeAction.edit);
}
return ret;
}

6
src/vs/workbench/api/node/extHostTypes.ts
View File

@@ -819,11 +819,11 @@ export class CodeAction {
dianostics?: Diagnostic[];
scope?: CodeActionKind;
kind?: CodeActionKind;
constructor(title: string, edit?: WorkspaceEdit) {
constructor(title: string, kind?: CodeActionKind) {
this.title = title;
this.edit = edit;
this.kind = kind;
}
}