From 475d0c85af98d3a5c8862481dc3180bb5019d34c Mon Sep 17 00:00:00 2001 From: Matt Bierner <12821956+mjbvz@users.noreply.github.com> Date: Mon, 24 Nov 2025 17:19:45 -0800 Subject: [PATCH 1/2] Remove build-script PR check For #277526 Our build scripts no longer require being compiled so we can skip the extra check --- .github/workflows/pr.yml | 7 ++----- build/package.json | 3 +-- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index b0b2ed66321..8495f37175e 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -72,13 +72,10 @@ jobs: mkdir -p .build/node_modules_cache tar -czf .build/node_modules_cache/cache.tgz --files-from .build/node_modules_list.txt - - name: Compile /build/ folder - run: npm run compile + - name: Type check /build/ scripts + run: npm run typecheck working-directory: build - - name: Check /build/ folder - run: .github/workflows/check-clean-git-state.sh - - name: Compile & Hygiene run: npm exec -- npm-run-all -lp core-ci extensions-ci hygiene eslint valid-layers-check define-class-fields-check vscode-dts-compile-check tsec-compile-check test-build-scripts env: diff --git a/build/package.json b/build/package.json index 3e2b16aa73d..39db6b7dffa 100644 --- a/build/package.json +++ b/build/package.json @@ -65,9 +65,8 @@ "type": "module", "scripts": { "copy-policy-dto": "node lib/policies/copyPolicyDto.ts", - "prebuild-ts": "npm run copy-policy-dto", + "pretypecheck": "npm run copy-policy-dto", "typecheck": "cd .. && npx tsgo --project build/tsconfig.json", - "compile": "npm run copy-policy-dto && npm run typecheck", "watch": "npm run typecheck -- --watch", "test": "mocha --ui tdd 'lib/**/*.test.ts'" }, From 15955a63fbe9655e2c4587e1bbeb83097777b2fd Mon Sep 17 00:00:00 2001 From: Matt Bierner <12821956+mjbvz@users.noreply.github.com> Date: Mon, 24 Nov 2025 18:22:24 -0800 Subject: [PATCH 2/2] Update `update-build-ts-version` script too --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 454fd11cf1a..63b62a654cb 100644 --- a/package.json +++ b/package.json @@ -69,7 +69,7 @@ "extensions-ci": "node ./node_modules/gulp/bin/gulp.js extensions-ci", "extensions-ci-pr": "node ./node_modules/gulp/bin/gulp.js extensions-ci-pr", "perf": "node scripts/code-perf.js", - "update-build-ts-version": "npm install -D typescript@next && npm install -D @typescript/native-preview && (cd build && npm run compile)" + "update-build-ts-version": "npm install -D typescript@next && npm install -D @typescript/native-preview && (cd build && npm run typecheck)" }, "dependencies": { "@microsoft/1ds-core-js": "^3.2.13",