Remove diff resource

This commit is contained in:
Logan Ramos
2021-09-08 14:20:08 -04:00
parent df115e761a
commit 65a8d1234c
5 changed files with 9 additions and 25 deletions

View File

@@ -642,7 +642,7 @@ export interface MainThreadEditorTabsShape extends IDisposable {
export interface IEditorTabDto {
viewColumn: EditorGroupColumn;
label: string;
resource?: UriComponents | { primary?: UriComponents, secondary?: UriComponents };
resource?: UriComponents;
editorId?: string;
isActive: boolean;
}

View File

@@ -6,7 +6,7 @@
import type * as vscode from 'vscode';
import * as typeConverters from 'vs/workbench/api/common/extHostTypeConverters';
import { IEditorTabDto, IExtHostEditorTabsShape } from 'vs/workbench/api/common/extHost.protocol';
import { URI, UriComponents } from 'vs/base/common/uri';
import { URI } from 'vs/base/common/uri';
import { Emitter, Event } from 'vs/base/common/event';
import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
import { ViewColumn } from 'vs/workbench/api/common/extHostTypes';
@@ -14,7 +14,7 @@ import { ViewColumn } from 'vs/workbench/api/common/extHostTypes';
export interface IEditorTab {
label: string;
viewColumn: ViewColumn;
resource?: vscode.Uri | { primary?: vscode.Uri, secondary?: vscode.Uri };
resource?: vscode.Uri;
editorId?: string;
isActive: boolean;
}
@@ -55,23 +55,10 @@ export class ExtHostEditorTabs implements IExtHostEditorTabs {
if (dto.isActive) {
activeIndex = index;
}
// Resolve resource into the right shape for either normal or side by side
let resource = undefined;
if (dto.resource) {
const resourceAsSidebySide = dto.resource as ({ primary?: UriComponents, secondary?: UriComponents });
if (resourceAsSidebySide.primary || resourceAsSidebySide.secondary) {
resource = {
primary: URI.revive(resourceAsSidebySide.primary),
secondary: URI.revive(resourceAsSidebySide.secondary)
};
} else {
resource = URI.revive(dto.resource as UriComponents | undefined);
}
}
return Object.freeze({
label: dto.label,
viewColumn: typeConverters.ViewColumn.to(dto.viewColumn),
resource,
resource: URI.revive(dto.resource),
editorId: dto.editorId,
isActive: dto.isActive
});