From 668d0cf4844cfb3818fed47fb411f5bb543d4b98 Mon Sep 17 00:00:00 2001 From: isidor Date: Wed, 24 Jun 2020 16:40:01 +0200 Subject: [PATCH] status bar: use better default for ariaLabel, get the codicon name since it is well represented #95360 --- src/vs/workbench/api/browser/mainThreadStatusBar.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/api/browser/mainThreadStatusBar.ts b/src/vs/workbench/api/browser/mainThreadStatusBar.ts index 754b9bc9569..09eff1450d0 100644 --- a/src/vs/workbench/api/browser/mainThreadStatusBar.ts +++ b/src/vs/workbench/api/browser/mainThreadStatusBar.ts @@ -15,6 +15,7 @@ import { IAccessibilityInformation } from 'vs/platform/accessibility/common/acce export class MainThreadStatusBar implements MainThreadStatusBarShape { private readonly entries: Map = new Map(); + static readonly CODICON_REGEXP = /\$\((.*?)\)/g; constructor( _extHostContext: IExtHostContext, @@ -32,7 +33,7 @@ export class MainThreadStatusBar implements MainThreadStatusBarShape { if (accessibilityInformation) { ariaLabel = accessibilityInformation.label; } else { - ariaLabel = text && text.indexOf('$(') === -1 ? text : tooltip || text; + ariaLabel = text ? text.replace(MainThreadStatusBar.CODICON_REGEXP, (_match, codiconName) => codiconName) : ''; } const entry: IStatusbarEntry = { text, tooltip, command, color, ariaLabel };