Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-24 12:19:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #261560 from microsoft/copilot/fix-260168

Browse Source 
Enable strict by default in implicit js/ts projects
This commit is contained in:
Matt Bierner
2025-08-14 12:36:38 -07:00
committed by GitHub
parent cb6ce89d0e 5f1c49b2e4
commit 6752afe8ad
4 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/typescript-language-features/package.json
View File

@@ -302,6 +302,12 @@
"markdownDescription": "%configuration.implicitProjectConfig.strictFunctionTypes%",
"scope": "window"
},
"js/ts.implicitProjectConfig.strict": {
"type": "boolean",
"default": true,
"markdownDescription": "%configuration.implicitProjectConfig.strict%",
"scope": "window"
},
"typescript.tsc.autoDetect": {
"type": "string",
"default": "on",

1
extensions/typescript-language-features/package.nls.json
View File

@@ -86,6 +86,7 @@
"configuration.implicitProjectConfig.experimentalDecorators": "Enable/disable `experimentalDecorators` in JavaScript files that are not part of a project. Existing `jsconfig.json` or `tsconfig.json` files override this setting.",
"configuration.implicitProjectConfig.strictNullChecks": "Enable/disable [strict null checks](https://www.typescriptlang.org/tsconfig#strictNullChecks) in JavaScript and TypeScript files that are not part of a project. Existing `jsconfig.json` or `tsconfig.json` files override this setting.",
"configuration.implicitProjectConfig.strictFunctionTypes": "Enable/disable [strict function types](https://www.typescriptlang.org/tsconfig#strictFunctionTypes) in JavaScript and TypeScript files that are not part of a project. Existing `jsconfig.json` or `tsconfig.json` files override this setting.",
"configuration.implicitProjectConfig.strict": "Enable/disable [strict mode](https://www.typescriptlang.org/tsconfig#strict) in JavaScript and TypeScript files that are not part of a project. Existing `jsconfig.json` or `tsconfig.json` files override this setting.",
"configuration.suggest.jsdoc.generateReturns": "Enable/disable generating `@returns` annotations for JSDoc templates.",
"configuration.suggest.autoImports": "Enable/disable auto import suggestions.",
"configuration.preferGoToSourceDefinition": "Makes `Go to Definition` avoid type declaration files when possible by triggering `Go to Source Definition` instead. This allows `Go to Source Definition` to be triggered with the mouse gesture.",

6
extensions/typescript-language-features/src/configuration/configuration.ts
View File

@@ -64,6 +64,7 @@ export class ImplicitProjectConfiguration {
public readonly experimentalDecorators: boolean;
public readonly strictNullChecks: boolean;
public readonly strictFunctionTypes: boolean;
public readonly strict: boolean;
constructor(configuration: vscode.WorkspaceConfiguration) {
this.target = ImplicitProjectConfiguration.readTarget(configuration);
@@ -72,6 +73,7 @@ export class ImplicitProjectConfiguration {
this.experimentalDecorators = ImplicitProjectConfiguration.readExperimentalDecorators(configuration);
this.strictNullChecks = ImplicitProjectConfiguration.readImplicitStrictNullChecks(configuration);
this.strictFunctionTypes = ImplicitProjectConfiguration.readImplicitStrictFunctionTypes(configuration);
this.strict = ImplicitProjectConfiguration.readImplicitStrict(configuration);
}
public isEqualTo(other: ImplicitProjectConfiguration): boolean {
@@ -101,6 +103,10 @@ export class ImplicitProjectConfiguration {
private static readImplicitStrictFunctionTypes(configuration: vscode.WorkspaceConfiguration): boolean {
return configuration.get<boolean>('js/ts.implicitProjectConfig.strictFunctionTypes', true);
}
private static readImplicitStrict(configuration: vscode.WorkspaceConfiguration): boolean {
return configuration.get<boolean>('js/ts.implicitProjectConfig.strict', true);
}
}
export interface TypeScriptServiceConfiguration {

4
extensions/typescript-language-features/src/tsconfig.ts
View File

@@ -55,6 +55,10 @@ export function inferredProjectCompilerOptions(
projectConfig.strictFunctionTypes = true;
}
if (serviceConfig.implicitProjectConfiguration.strict) {
projectConfig.strict = true;
}
if (serviceConfig.implicitProjectConfiguration.module) {
projectConfig.module = serviceConfig.implicitProjectConfiguration.module as Proto.ModuleKind;
}