From 675806facfdc81afdda4bb1a67d6ae7f8d738cec Mon Sep 17 00:00:00 2001 From: Johannes Date: Tue, 30 Aug 2022 12:40:47 +0200 Subject: [PATCH] The `TestTextFileEditor` doesn't use editor contribution anymore. This is because not every test disposes its code editors correctly and leaking contributions (like the `FoldingController`) have weird side-effects (still listening etc). Also, tests at the workbench level don't need editor contribution and editor construction is faster without them fyi @bpasero --- src/vs/workbench/test/browser/workbenchTestServices.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/test/browser/workbenchTestServices.ts b/src/vs/workbench/test/browser/workbenchTestServices.ts index 00a7696f69d..df2baa8a161 100644 --- a/src/vs/workbench/test/browser/workbenchTestServices.ts +++ b/src/vs/workbench/test/browser/workbenchTestServices.ts @@ -194,7 +194,7 @@ export class TestTextResourceEditor extends TextResourceEditor { export class TestTextFileEditor extends TextFileEditor { protected override createEditorControl(parent: HTMLElement, configuration: any): void { - this.editorControl = this.instantiationService.createInstance(TestCodeEditor, parent, configuration, {}); + this.editorControl = this.instantiationService.createInstance(TestCodeEditor, parent, configuration, { contributions: [] }); } setSelection(selection: Selection | undefined, reason: EditorPaneSelectionChangeReason): void {