From 67bafb26c599dd5a8ab780fe4d8cd38846f61aed Mon Sep 17 00:00:00 2001 From: Lee Murray Date: Fri, 27 Mar 2026 13:39:45 +0000 Subject: [PATCH] Improve focus styles for action items in auxiliary bar and panel (#305594) * Improve focus styles for action items in auxiliary bar and panel * Update src/vs/sessions/browser/parts/media/panelPart.css Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/vs/sessions/browser/parts/media/auxiliaryBarPart.css Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/vs/sessions/browser/parts/media/panelPart.css Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: mrleemurray Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .../sessions/browser/parts/media/auxiliaryBarPart.css | 7 +++++-- src/vs/sessions/browser/parts/media/panelPart.css | 10 ++++++++-- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/vs/sessions/browser/parts/media/auxiliaryBarPart.css b/src/vs/sessions/browser/parts/media/auxiliaryBarPart.css index d3802d00b10..abb40cea4b4 100644 --- a/src/vs/sessions/browser/parts/media/auxiliaryBarPart.css +++ b/src/vs/sessions/browser/parts/media/auxiliaryBarPart.css @@ -31,10 +31,13 @@ background-color: var(--vscode-sessionsAuxiliaryBar-background); } -/* Hide the underline indicator entirely */ -.agent-sessions-workbench .part.auxiliarybar > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item .active-item-indicator:before { +/* Hide the underline indicator for non-focused items, but keep it for keyboard focus */ +.agent-sessions-workbench .part.auxiliarybar > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item:not(:focus-visible) .active-item-indicator:before { display: none !important; } +.agent-sessions-workbench .part.auxiliarybar > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item:focus-visible .active-item-indicator:before { + display: block !important; +} /* Active/checked state: background container instead of underline */ .agent-sessions-workbench .part.auxiliarybar > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item.checked { diff --git a/src/vs/sessions/browser/parts/media/panelPart.css b/src/vs/sessions/browser/parts/media/panelPart.css index 7156bcb1d91..b66897c0840 100644 --- a/src/vs/sessions/browser/parts/media/panelPart.css +++ b/src/vs/sessions/browser/parts/media/panelPart.css @@ -10,10 +10,16 @@ /* ===== Modern action label styling for sessions panel ===== */ -/* Hide the underline indicator entirely */ -.agent-sessions-workbench .part.panel > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item .active-item-indicator:before { +/* Hide the underline indicator for non-focused, non-checked items; keep it for focus-visible and checked */ +.agent-sessions-workbench .part.panel > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item:not(:focus-visible):not(.checked) .active-item-indicator:before { display: none !important; } +.agent-sessions-workbench .part.panel > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item:focus-visible .active-item-indicator:before { + display: block !important; +} +.agent-sessions-workbench .part.panel > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item.checked .active-item-indicator:before { + display: block !important; +} /* Make icon action items 24px tall */ .agent-sessions-workbench .part.panel > .title > .composite-bar-container > .composite-bar > .monaco-action-bar .action-item.icon {