From 69682cabda74704ff848e0b71bfd7d169bfb58dc Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Wed, 23 Mar 2016 15:01:45 +0100 Subject: [PATCH] Cannot read property 'dispose' of undefined (fixes #4576) --- .../parts/quickopen/browser/quickOpenModel.ts | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/src/vs/base/parts/quickopen/browser/quickOpenModel.ts b/src/vs/base/parts/quickopen/browser/quickOpenModel.ts index 70d15896e08..75e7c1a855a 100644 --- a/src/vs/base/parts/quickopen/browser/quickOpenModel.ts +++ b/src/vs/base/parts/quickopen/browser/quickOpenModel.ts @@ -650,21 +650,21 @@ class Renderer implements IRenderer { public disposeTemplate(templateId: string, templateData: any): void { if (templateId === templateEntryItem) { this.entryItemRenderer.disposeTemplate(null, templateId, templateData); + } else { + const data = templateData as IQuickOpenEntryGroupTemplateData; + data.actionBar.dispose(); + data.actionBar = null; + data.container = null; + data.description.dispose(); + data.description = null; + data.detail.dispose(); + data.detail = null; + data.group = null; + data.icon = null; + data.label.dispose(); + data.label = null; + data.prefix = null; } - - const data = templateData as IQuickOpenEntryGroupTemplateData; - data.actionBar.dispose(); - data.actionBar = null; - data.container = null; - data.description.dispose(); - data.description = null; - data.detail.dispose(); - data.detail = null; - data.group = null; - data.icon = null; - data.label.dispose(); - data.label = null; - data.prefix = null; } }