Properly duplicate TaskGroup

This commit is contained in:
Alex Ross
2021-08-23 14:59:52 +02:00
parent 369c6efae5
commit 69936d5999
2 changed files with 3 additions and 4 deletions

View File

@@ -8,7 +8,6 @@ import { asPromise } from 'vs/base/common/async';
import { Event, Emitter } from 'vs/base/common/event';
import { MainContext, MainThreadTaskShape, ExtHostTaskShape } from 'vs/workbench/api/common/extHost.protocol';
import * as Objects from 'vs/base/common/objects';
import * as types from 'vs/workbench/api/common/extHostTypes';
import { IExtHostWorkspaceProvider, IExtHostWorkspace } from 'vs/workbench/api/common/extHostWorkspace';
import type * as vscode from 'vscode';
@@ -320,7 +319,7 @@ export namespace TaskDTO {
if (value.group !== undefined) {
result.group = types.TaskGroup.from(value.group._id);
if (result.group) {
result.group = Objects.deepClone(result.group);
result.group = new types.TaskGroup(result.group.id, result.group.label);
if (value.group.isDefault) {
result.group.isDefault = value.group.isDefault;
}

View File

@@ -1795,11 +1795,11 @@ export class TaskGroup implements vscode.TaskGroup {
}
}
constructor(id: string, _label: string) {
constructor(id: string, public readonly label: string) {
if (typeof id !== 'string') {
throw illegalArgument('name');
}
if (typeof _label !== 'string') {
if (typeof label !== 'string') {
throw illegalArgument('name');
}
this._id = id;