Extract areLanguageDiagnosticSettingsEqual

This commit is contained in:
Matt Bierner
2019-06-07 11:22:06 -07:00
parent a87c73527e
commit 69a7b7ef24

View File

@@ -93,6 +93,11 @@ interface LanguageDiagnosticSettings {
readonly enableSuggestions: boolean;
}
function areLanguageDiagnosticSettingsEqual(currentSettings: LanguageDiagnosticSettings, newSettings: LanguageDiagnosticSettings): boolean {
return currentSettings.validate === newSettings.validate
&& currentSettings.enableSuggestions && currentSettings.enableSuggestions;
}
class DiagnosticSettings {
private static readonly defaultSettings: LanguageDiagnosticSettings = {
validate: true,
@@ -131,8 +136,7 @@ class DiagnosticSettings {
const currentSettings = this.get(language);
const newSettings = f(currentSettings);
this._languageSettings.set(language, newSettings);
return currentSettings.validate === newSettings.validate
&& currentSettings.enableSuggestions && currentSettings.enableSuggestions;
return areLanguageDiagnosticSettingsEqual(currentSettings, newSettings);
}
}
@@ -238,4 +242,4 @@ export class DiagnosticsManager {
this._currentDiagnostics.set(fileDiagnostic.file, fileDiagnostic.getDiagnostics(this._settings));
}
}
}
}