ref #44776 Only test the logic of parsing git show output

* Instead of testing it through `getCommit` as we don't use stub in test
This commit is contained in:
Ryuichi Inagaki
2018-04-11 20:02:20 +10:00
parent 278842c987
commit 6b7a644082
2 changed files with 39 additions and 52 deletions

View File

@@ -6,7 +6,7 @@
'use strict';
import 'mocha';
import { Git, GitStatusParser, Repository, parseGitmodules } from '../git';
import { Git, GitStatusParser, Repository, parseGitCommit, parseGitmodules } from '../git';
import * as assert from 'assert';
import * as sinon from 'sinon';
@@ -177,63 +177,47 @@ suite('git', () => {
});
});
suite('Repository', () => {
const spawnOption = {};
suite('getCommit', () => {
suite('parseGitCommit', () => {
test('single previous commit', () => {
const GIT_OUTPUT_SINGLE_PARENT = `52c293a05038d865604c2284aa8698bd087915a1
8e5a374372b8393906c7e380dbb09349c5385554
This is a commit message.`;
assert.deepEqual(parseGitCommit(GIT_OUTPUT_SINGLE_PARENT), {
hash: '52c293a05038d865604c2284aa8698bd087915a1',
message: 'This is a commit message.',
previousHashes: ['8e5a374372b8393906c7e380dbb09349c5385554']
});
});
test('multiple previous commits', () => {
const GIT_OUTPUT_MULTIPLE_PARENTS = `52c293a05038d865604c2284aa8698bd087915a1
8e5a374372b8393906c7e380dbb09349c5385554 df27d8c75b129ab9b178b386077da2822101b217
This is a commit message.`;
assert.deepEqual(parseGitCommit(GIT_OUTPUT_MULTIPLE_PARENTS), {
hash: '52c293a05038d865604c2284aa8698bd087915a1',
message: 'This is a commit message.',
previousHashes: ['8e5a374372b8393906c7e380dbb09349c5385554', 'df27d8c75b129ab9b178b386077da2822101b217']
});
});
test('no previous commits', async () => {
const GIT_OUTPUT_NO_PARENTS = `52c293a05038d865604c2284aa8698bd087915a1
This is a commit message.`;
const git = sinon.createStubInstance(Git);
git.exec = stub([
{
withArgs: ['REPOSITORY_ROOT', ['show', '-s', '--format=%H\n%P\n%B', 'REF_SINGLE_PARENT'], spawnOption],
returns: GIT_OUTPUT_SINGLE_PARENT
}, {
withArgs: ['REPOSITORY_ROOT', ['show', '-s', '--format=%H\n%P\n%B', 'REF_MULTIPLE_PARENTS'], spawnOption],
returns: GIT_OUTPUT_MULTIPLE_PARENTS
}, {
withArgs: ['REPOSITORY_ROOT', ['show', '-s', '--format=%H\n%P\n%B', 'REF_NO_PARENTS'], spawnOption],
returns: GIT_OUTPUT_NO_PARENTS
}
]);
const repository = new Repository(git, 'REPOSITORY_ROOT');
test('get commit', async () => {
assert.deepEqual(await repository.getCommit('REF_SINGLE_PARENT'), {
hash: '52c293a05038d865604c2284aa8698bd087915a1',
message: 'This is a commit message.',
previousHashes: ['8e5a374372b8393906c7e380dbb09349c5385554']
});
assert.deepEqual(parseGitCommit(GIT_OUTPUT_NO_PARENTS), {
hash: '52c293a05038d865604c2284aa8698bd087915a1',
message: 'This is a commit message.',
previousHashes: []
});
test('multiple previous commits', async () => {
const commit = await repository.getCommit('REF_MULTIPLE_PARENTS');
assert.deepEqual(commit.previousHashes, ['8e5a374372b8393906c7e380dbb09349c5385554', 'df27d8c75b129ab9b178b386077da2822101b217']);
});
test('no previous commits', async () => {
const commit = await repository.getCommit('REF_NO_PARENTS');
assert.deepEqual(commit.previousHashes, []);
});
function stub(argOutputPairs: {withArgs: any[], returns: string}[]): sinon.SinonStub {
const stub = sinon.stub();
argOutputPairs.forEach(({withArgs, returns}) => {
stub.withArgs(...withArgs).returns(Promise.resolve({stdout: returns}));
});
return stub;
}
});
});
suite('Repository', () => {
suite('deleteRef', () => {
const spawnOption = {};
const git = sinon.createStubInstance(Git);
git.exec = sinon.spy();
const repository = new Repository(git, 'REPOSITORY_ROOT');