Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-08 09:08:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

Enable strictNullChecks for implicit projects (#149844)

Browse Source 
Mistakenly enabled checkJS instead of strictNullChecks
This commit is contained in:
Matt Bierner
2022-05-18 10:47:37 -07:00
committed by GitHub
parent ff975bc211
commit 6bd7605ae1
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extensions/typescript-language-features/package.json
+2 -2
View File
@@ -686,7 +686,7 @@
}, },
"js/ts.implicitProjectConfig.checkJs": { "js/ts.implicitProjectConfig.checkJs": {
"type": "boolean", "type": "boolean",
"default": true, "default": false,
"markdownDescription": "%configuration.implicitProjectConfig.checkJs%", "markdownDescription": "%configuration.implicitProjectConfig.checkJs%",
"scope": "window" "scope": "window"
}, },
@@ -705,7 +705,7 @@
}, },
"js/ts.implicitProjectConfig.strictNullChecks": { "js/ts.implicitProjectConfig.strictNullChecks": {
"type": "boolean", "type": "boolean",
"default": false, "default": true,
"markdownDescription": "%configuration.implicitProjectConfig.strictNullChecks%", "markdownDescription": "%configuration.implicitProjectConfig.strictNullChecks%",
"scope": "window" "scope": "window"
}, },
extensions/typescript-language-features/src/utils/configuration.ts
+2 -2
View File
@@ -82,7 +82,7 @@ export class ImplicitProjectConfiguration {
private static readCheckJs(configuration: vscode.WorkspaceConfiguration): boolean { private static readCheckJs(configuration: vscode.WorkspaceConfiguration): boolean {
return configuration.get<boolean>('js/ts.implicitProjectConfig.checkJs') return configuration.get<boolean>('js/ts.implicitProjectConfig.checkJs')
?? configuration.get<boolean>('javascript.implicitProjectConfig.checkJs', true); ?? configuration.get<boolean>('javascript.implicitProjectConfig.checkJs', false);
} }
private static readExperimentalDecorators(configuration: vscode.WorkspaceConfiguration): boolean { private static readExperimentalDecorators(configuration: vscode.WorkspaceConfiguration): boolean {
@@ -91,7 +91,7 @@ export class ImplicitProjectConfiguration {
} }
private static readImplicitStrictNullChecks(configuration: vscode.WorkspaceConfiguration): boolean { private static readImplicitStrictNullChecks(configuration: vscode.WorkspaceConfiguration): boolean {
return configuration.get<boolean>('js/ts.implicitProjectConfig.strictNullChecks', false); return configuration.get<boolean>('js/ts.implicitProjectConfig.strictNullChecks', true);
} }
private static readImplicitStrictFunctionTypes(configuration: vscode.WorkspaceConfiguration): boolean { private static readImplicitStrictFunctionTypes(configuration: vscode.WorkspaceConfiguration): boolean {