diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts index b70d5c100a4..02447bd7aaa 100644 --- a/src/vs/vscode.proposed.d.ts +++ b/src/vs/vscode.proposed.d.ts @@ -1912,11 +1912,6 @@ declare module 'vscode' { // backup?(document: NotebookDocument, cancellation: CancellationToken): Thenable; kernel?: NotebookKernel; - - /** - * Responsible for filling in outputs for the cell - */ - executeCell(document: NotebookDocument, cell: NotebookCell | undefined, token: CancellationToken): Promise; } export interface NotebookKernel { diff --git a/src/vs/workbench/api/common/extHostNotebook.ts b/src/vs/workbench/api/common/extHostNotebook.ts index 61169e6cc91..6fabf83a93b 100644 --- a/src/vs/workbench/api/common/extHostNotebook.ts +++ b/src/vs/workbench/api/common/extHostNotebook.ts @@ -807,6 +807,10 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN throw new Error(`Notebook provider for '${viewType}' already registered`); } + if ((provider).executeCell) { + throw new Error('NotebookContentKernel.executeCell is removed, please use vscode.notebook.registerNotebookKernel instead.'); + } + this._notebookContentProviders.set(viewType, { extension, provider }); this._proxy.$registerNotebookProvider({ id: extension.identifier, location: extension.extensionLocation }, viewType, provider.kernel ? { id: viewType, label: provider.kernel.label, extensionLocation: extension.extensionLocation, preloads: provider.kernel.preloads } : undefined); return new extHostTypes.Disposable(() => { @@ -963,8 +967,6 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN } else { return provider.kernel.executeAllCells(document, token); } - } else { - return provider.executeCell(document, cell, token); } } }