Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-27 12:04:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

simple capping of number of canonical uris, https://github.com/microsoft/vscode/issues/93368

Browse Source
This commit is contained in:
Johannes Rieken
2020-05-20 16:43:03 +02:00
parent 90b337af5c
commit 6e3245c7ac
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/vs/workbench/services/uriIdentity/common/uriIdentityService.ts
View File

@@ -15,7 +15,9 @@ export class UriIdentityService implements IUriIdentityService {
_serviceBrand: undefined;
readonly extUri: IExtUri;
private _canonicalUris: URI[] = []; // use SkipList or BinaryTree instead of array...
private readonly _limit = 10_000;
constructor(@IFileService private readonly _fileService: IFileService) {
@@ -51,16 +53,16 @@ export class UriIdentityService implements IUriIdentityService {
}
// (2) find the uri in its canonical form or use this uri to define it
// perf@jrieken
// * using a SkipList or BinaryTree for faster insertion
const idx = binarySearch(this._canonicalUris, uri, (a, b) => this.extUri.compare(a, b, true));
if (idx >= 0) {
return this._canonicalUris[idx].with({ fragment: uri.fragment });
}
// using slice/concat is faster than splice
const before = this._canonicalUris.slice(0, ~idx);
const after = this._canonicalUris.slice(~idx);
// total len should be being _limit and 2*_limit
const insertIdx = ~idx;
const before = this._canonicalUris.slice(Math.max(0, insertIdx - this._limit), insertIdx);
const after = this._canonicalUris.slice(insertIdx, insertIdx + this._limit);
this._canonicalUris = before.concat(uri.with({ fragment: null }), after);
return uri;
}