From 6e6ef83a2a13dcff87debe01e07d7b65645b8bb5 Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Fri, 28 Feb 2025 09:55:53 +0100 Subject: [PATCH] terminal - use `product` to figure out `quality` (#242226) --- src/vs/platform/product/common/product.ts | 7 +++---- .../contrib/terminal/common/terminalConfiguration.ts | 4 ++-- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/vs/platform/product/common/product.ts b/src/vs/platform/product/common/product.ts index 1a2a6192ec8..d27cdce900f 100644 --- a/src/vs/platform/product/common/product.ts +++ b/src/vs/platform/product/common/product.ts @@ -8,7 +8,9 @@ import { IProductConfiguration } from '../../../base/common/product.js'; import { ISandboxConfiguration } from '../../../base/parts/sandbox/common/sandboxTypes.js'; /** - * @deprecated You MUST use `IProductService` if possible. + * @deprecated It is preferred that you use `IProductService` if you can. This + * allows web embedders to override our defaults. But for things like `product.quality`, + * the use is fine because that property is not overridable. */ let product: IProductConfiguration; @@ -72,7 +74,4 @@ else { } } -/** - * @deprecated You MUST use `IProductService` if possible. - */ export default product; diff --git a/src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts b/src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts index 27802785405..22c9690746d 100644 --- a/src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts +++ b/src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts @@ -486,7 +486,7 @@ const terminalConfiguration: IConfigurationNode = { markdownDescription: localize('terminal.integrated.windowsUseConptyDll', "Whether to use the experimental conpty.dll (v1.22.250204002) shipped with VS Code, instead of the one bundled with Windows."), type: 'boolean', tags: ['preview'], - default: product.quality !== 'stable', + default: product.quality !== 'stable' }, [TerminalSettingId.SplitCwd]: { description: localize('terminal.integrated.splitCwd', "Controls the working directory a split terminal starts with."), @@ -610,7 +610,7 @@ const terminalConfiguration: IConfigurationNode = { [TerminalSettingId.ShellIntegrationEnvironmentReporting]: { markdownDescription: localize('terminal.integrated.shellIntegration.environmentReporting', "Controls whether to report the shell environment, enabling its use in features such as {0}. This may cause a slowdown when printing your shell's prompt.", `\`#${TerminalContribSettingId.SuggestEnabled}#\``), type: 'boolean', - default: product.quality !== 'stable', + default: product.quality !== 'stable' }, [TerminalSettingId.SmoothScrolling]: { markdownDescription: localize('terminal.integrated.smoothScrolling', "Controls whether the terminal will scroll using an animation."),