From 6f0ce2e750894f53376dbc8166189a17308abfe3 Mon Sep 17 00:00:00 2001 From: Jackson Kearl Date: Wed, 2 Jun 2021 18:30:01 -0700 Subject: [PATCH] Fix #125250 --- .../contrib/searchEditor/browser/searchEditorInput.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/vs/workbench/contrib/searchEditor/browser/searchEditorInput.ts b/src/vs/workbench/contrib/searchEditor/browser/searchEditorInput.ts index 908e0244241..c831ac89ffa 100644 --- a/src/vs/workbench/contrib/searchEditor/browser/searchEditorInput.ts +++ b/src/vs/workbench/contrib/searchEditor/browser/searchEditorInput.ts @@ -148,10 +148,12 @@ export class SearchEditorInput extends EditorInput { this._cachedResultsModel = data.resultsModel; this._cachedConfigurationModel = data.configurationModel; this._onDidChangeLabel.fire(); - this._register(this._cachedConfigurationModel.onConfigDidUpdate(() => { - this._onDidChangeLabel.fire(); - this.memento.getMemento(StorageScope.WORKSPACE, StorageTarget.MACHINE).searchConfig = this._cachedConfigurationModel?.config; - })); + if (!this.isDisposed()) { + this._register(this._cachedConfigurationModel.onConfigDidUpdate(() => { + this._onDidChangeLabel.fire(); + this.memento.getMemento(StorageScope.WORKSPACE, StorageTarget.MACHINE).searchConfig = this._cachedConfigurationModel?.config; + })); + } return data; }); }