Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 02:28:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #27581: Unspecific names: TerminalBehaviour and RevealKind

Browse Source
This commit is contained in:
Dirk Baeumer
2017-05-30 21:59:20 +02:00
parent 8afd3ffb65
commit 6fb0af28cd
4 changed files with 44 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/vs/workbench/api/node/extHostTask.ts
View File

@@ -191,15 +191,15 @@ namespace ProblemMatcher {
}
*/
namespace RevealKind {
export function from(value: vscode.RevealKind): TaskSystem.RevealKind {
namespace TaskRevealKind {
export function from(value: vscode.TaskRevealKind): TaskSystem.RevealKind {
if (value === void 0 || value === null) {
return TaskSystem.RevealKind.Always;
}
switch (value) {
case types.RevealKind.Silent:
case types.TaskRevealKind.Silent:
return TaskSystem.RevealKind.Silent;
case types.RevealKind.Never:
case types.TaskRevealKind.Never:
return TaskSystem.RevealKind.Never;
}
return TaskSystem.RevealKind.Always;
@@ -207,11 +207,11 @@ namespace RevealKind {
}
namespace TerminalBehaviour {
export function from(value: vscode.TerminalBehaviour): TaskSystem.TerminalBehavior {
export function from(value: vscode.TaskTerminalBehavior): TaskSystem.TerminalBehavior {
if (value === void 0 || value === null) {
return { reveal: TaskSystem.RevealKind.Always, echo: false };
}
return { reveal: RevealKind.from(value.reveal), echo: !!value.echo };
return { reveal: TaskRevealKind.from(value.reveal), echo: !!value.echo };
}
}
@@ -230,10 +230,10 @@ namespace Strings {
}
namespace CommandOptions {
function isShellOptions(value: any): value is vscode.ShellOptions {
function isShellOptions(value: any): value is vscode.ShellTaskOptions {
return value && typeof value.executable === 'string';
}
export function from(value: vscode.ShellOptions | vscode.ProcessOptions): TaskSystem.CommandOptions {
export function from(value: vscode.ShellTaskOptions | vscode.ProcessTaskOptions): TaskSystem.CommandOptions {
if (value === void 0 || value === null) {
return undefined;
}