Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-23 03:39:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Never return undefined for cachedResponse.execute

Browse Source
This commit is contained in:
Matt Bierner
2018-12-07 11:49:06 -08:00
parent 98605b6a4e
commit 7140c91245
3 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/typescript-language-features/src/features/baseCodeLensProvider.ts
View File

@@ -54,7 +54,7 @@ export abstract class TypeScriptBaseCodeLensProvider implements vscode.CodeLensP
}
const response = await this.cachedResponse.execute(document, () => this.client.execute('navtree', { file: filepath }, token));
if (!response || response.type !== 'response') {
if (response.type !== 'response') {
return [];
}

2
extensions/typescript-language-features/src/features/documentSymbol.ts
View File

@@ -43,7 +43,7 @@ class TypeScriptDocumentSymbolProvider implements vscode.DocumentSymbolProvider
const args: Proto.FileRequestArgs = { file };
const response = await this.cachedResponse.execute(resource, () => this.client.execute('navtree', args, token));
if (!response || response.type !== 'response' || !response.body) {
if (response.type !== 'response' || !response.body) {
return undefined;
}

7
extensions/typescript-language-features/src/tsServer/cachedResponse.ts
View File

@@ -12,8 +12,11 @@ export class CachedResponse<T extends Proto.Response> {
private version: number = -1;
private document: string = '';
public execute(document: vscode.TextDocument, f: () => Promise<ServerResponse<T>>) {
if (this.matches(document)) {
public execute(
document: vscode.TextDocument,
f: () => Promise<ServerResponse<T>>
): Promise<ServerResponse<T>> {
if (this.response && this.matches(document)) {
return this.response;
}
return this.update(document, f());