Finalize terminal color API (#130123)

* fix #128228

* Update src/vs/vscode.d.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* Update src/vs/vscode.d.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>

* redo commit

* remove from proposed api

* improve description

Co-authored-by: Megan Rogge <meganrogge@Megans-MBP.lan>
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
This commit is contained in:
Megan Rogge
2021-08-10 11:59:29 -04:00
committed by GitHub
parent 24dbdb2c5f
commit 72190f7c69
3 changed files with 14 additions and 19 deletions

View File

@@ -642,9 +642,6 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I
},
createTerminal(nameOrOptions?: vscode.TerminalOptions | vscode.ExtensionTerminalOptions | string, shellPath?: string, shellArgs?: string[] | string): vscode.Terminal {
if (typeof nameOrOptions === 'object') {
if (nameOrOptions.color) {
checkProposedApiEnabled(extension);
}
if ('pty' in nameOrOptions) {
return extHostTerminalService.createExtensionTerminal(nameOrOptions);
}