From 7283f5cb7c099ccd052e5abc2d7495cb93c93fbb Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Tue, 12 Oct 2021 13:12:00 +0200 Subject: [PATCH] fix https://github.com/microsoft/vscode/issues/130057 --- .../src/singlefolder-tests/notebook.editor.test.ts | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/extensions/vscode-api-tests/src/singlefolder-tests/notebook.editor.test.ts b/extensions/vscode-api-tests/src/singlefolder-tests/notebook.editor.test.ts index 2f58ad3a704..3823e543c60 100644 --- a/extensions/vscode-api-tests/src/singlefolder-tests/notebook.editor.test.ts +++ b/extensions/vscode-api-tests/src/singlefolder-tests/notebook.editor.test.ts @@ -46,17 +46,22 @@ suite.skip('Notebook Editor', function () { test('showNotebookDocment', async function () { - const p = utils.asPromise(vscode.workspace.onDidOpenNotebookDocument); + const notebookDocumentsFromOnDidOpen = new Set(); + const sub = vscode.workspace.onDidOpenNotebookDocument(e => { + notebookDocumentsFromOnDidOpen.add(e); + }); + const uri = await utils.createRandomFile(undefined, undefined, '.nbdtest'); const editor = await vscode.window.showNotebookDocument(uri); assert.strictEqual(uri.toString(), editor.document.uri.toString()); - const event = await p; - assert.strictEqual(event.uri.toString(), uri.toString()); + assert.strictEqual(notebookDocumentsFromOnDidOpen.has(editor.document), true); const includes = vscode.workspace.notebookDocuments.includes(editor.document); assert.strictEqual(true, includes); + + sub.dispose(); }); // TODO@rebornix deal with getting started