From 73f20ecd0aeb0ff407e1de65f42577bdae5af34d Mon Sep 17 00:00:00 2001
From: SteVen Batten <stbatt@microsoft.com>
Date: Wed, 26 Jun 2019 17:25:13 -0700
Subject: [PATCH] menubar tab fix

---
 src/vs/base/browser/ui/menu/menubar.ts | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/vs/base/browser/ui/menu/menubar.ts b/src/vs/base/browser/ui/menu/menubar.ts
index b9d8ff55262..1ffcb47b9a1 100644
--- a/src/vs/base/browser/ui/menu/menubar.ts
+++ b/src/vs/base/browser/ui/menu/menubar.ts
@@ -119,7 +119,7 @@ export class MenuBar extends Disposable {
 
 			if (event.equals(KeyCode.LeftArrow) || (isMacintosh && event.equals(KeyCode.Tab | KeyMod.Shift))) {
 				this.focusPrevious();
-			} else if (event.equals(KeyCode.RightArrow) || event.equals(KeyCode.Tab)) {
+			} else if (event.equals(KeyCode.RightArrow) || (isMacintosh && event.equals(KeyCode.Tab))) {
 				this.focusNext();
 			} else if (event.equals(KeyCode.Escape) && this.isFocused && !this.isOpen) {
 				this.setUnfocusedState();
@@ -130,6 +130,11 @@ export class MenuBar extends Disposable {
 				eventHandled = false;
 			}
 
+			// Never allow default tab behavior
+			if (event.equals(KeyCode.Tab | KeyMod.Shift) || event.equals(KeyCode.Tab)) {
+				event.preventDefault();
+			}
+
 			if (eventHandled) {
 				event.preventDefault();
 				event.stopPropagation();