Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-02 06:21:50 +01:00
Code Issues Packages Projects Releases Wiki Activity

Convert many simple getters for events into readonly properties

Browse Source 
We seem to use the readonly property way of exposing these values more widely. Standardizing this a bit across the codebase
This commit is contained in:
Matt Bierner
2019-07-15 16:12:25 -07:00
parent 20d2018d18
commit 7411e3f341
62 changed files with 154 additions and 157 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/vs/workbench/common/editor.ts
View File

@@ -330,13 +330,13 @@ export interface IEditorInput extends IDisposable {
export abstract class EditorInput extends Disposable implements IEditorInput {
protected readonly _onDidChangeDirty: Emitter<void> = this._register(new Emitter<void>());
get onDidChangeDirty(): Event<void> { return this._onDidChangeDirty.event; }
readonly onDidChangeDirty: Event<void> = this._onDidChangeDirty.event;
protected readonly _onDidChangeLabel: Emitter<void> = this._register(new Emitter<void>());
get onDidChangeLabel(): Event<void> { return this._onDidChangeLabel.event; }
readonly onDidChangeLabel: Event<void> = this._onDidChangeLabel.event;
private readonly _onDispose: Emitter<void> = this._register(new Emitter<void>());
get onDispose(): Event<void> { return this._onDispose.event; }
readonly onDispose: Event<void> = this._onDispose.event;
private disposed: boolean = false;
@@ -658,7 +658,7 @@ export interface ITextEditorModel extends IEditorModel {
export class EditorModel extends Disposable implements IEditorModel {
private readonly _onDispose: Emitter<void> = this._register(new Emitter<void>());
get onDispose(): Event<void> { return this._onDispose.event; }
readonly onDispose: Event<void> = this._onDispose.event;
/**
* Causes this model to load returning a promise when loading is completed.