Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 18:49:00 +01:00
Code Issues Packages Projects Releases Wiki Activity

Git protocol handler improvements (#162144)

Browse Source
This commit is contained in:
Ladislau Szomoru
2022-09-28 11:58:10 +02:00
committed by GitHub
parent 8044546365
commit 7559012a34
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
extensions/git/src/protocolHandler.ts
View File

@@ -12,6 +12,7 @@ import * as querystring from 'querystring';
import { OutputChannelLogger } from './log';
const schemes = new Set(['file', 'git', 'http', 'https', 'ssh']);
const refRegEx = /^$|[~\^:\\\*\s\[\]]|^-|^\.|\/\.|\.\.|\.lock\/|\.lock$|\/$|\.$/;
export class GitProtocolHandler implements UriHandler {
@@ -44,7 +45,7 @@ export class GitProtocolHandler implements UriHandler {
}
if (ref !== undefined && typeof ref !== 'string') {
this.outputChannelLogger.logWarning('Failed to open URI:' + uri.toString());
this.outputChannelLogger.logWarning('Failed to open URI due to multiple references:' + uri.toString());
return;
}
@@ -62,6 +63,11 @@ export class GitProtocolHandler implements UriHandler {
if (!schemes.has(cloneUri.scheme.toLowerCase())) {
throw new Error('Unsupported scheme.');
}
// Validate the reference
if (typeof ref === 'string' && refRegEx.test(ref)) {
throw new Error('Invalid reference.');
}
}
catch (ex) {
this.outputChannelLogger.logWarning('Invalid URI:' + uri.toString());