From 76007c48fd6a47e9def809d18d8a35d128f8414d Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Fri, 16 Dec 2016 14:03:09 -0800 Subject: [PATCH] Fix package.json Auto complete Fixes #17342 **Bug** I believe that 739d8ca77f6215a5a385587e6e6c7d66fdbe15c6 introduced a regression for package.json auto complete where we end up inserting the text `*` for the package.version **Fix** Insert `""` instead of star to match previous behavior better --- extensions/javascript/src/features/packageJSONContribution.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extensions/javascript/src/features/packageJSONContribution.ts b/extensions/javascript/src/features/packageJSONContribution.ts index 25f26865f57..573b8b1608f 100644 --- a/extensions/javascript/src/features/packageJSONContribution.ts +++ b/extensions/javascript/src/features/packageJSONContribution.ts @@ -67,7 +67,7 @@ export class PackageJSONContribution implements IJSONContribution { let name = keys[0]; let insertText = new SnippetString().appendText(JSON.stringify(name)); if (addValue) { - insertText.appendText(': ').appendPlaceholder('*'); + insertText.appendText(': "').appendPlaceholder('').appendText('"'); if (!isLast) { insertText.appendText(','); } @@ -99,7 +99,7 @@ export class PackageJSONContribution implements IJSONContribution { this.mostDependedOn.forEach((name) => { let insertText = new SnippetString().appendText(JSON.stringify(name)); if (addValue) { - insertText.appendText(': ').appendPlaceholder('*'); + insertText.appendText(': "').appendPlaceholder('').appendText('"'); if (!isLast) { insertText.appendText(','); }