diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts index f4711ab88a4..3637da92959 100644 --- a/src/vs/vscode.proposed.d.ts +++ b/src/vs/vscode.proposed.d.ts @@ -170,10 +170,15 @@ declare module 'vscode' { /** * Fired when the list of tunnels has changed. + * @deprecated use onDidChangeTunnels instead */ // TODO@alexr // eslint-disable-next-line vscode-dts-event-naming export const onDidTunnelsChange: Event; + /** + * Fired when the list of tunnels has changed. + */ + export const onDidChangeTunnels: Event; } export interface ResourceLabelFormatter { diff --git a/src/vs/workbench/api/common/extHost.api.impl.ts b/src/vs/workbench/api/common/extHost.api.impl.ts index 0ce895559ea..96b5fdbfb5e 100644 --- a/src/vs/workbench/api/common/extHost.api.impl.ts +++ b/src/vs/workbench/api/common/extHost.api.impl.ts @@ -757,9 +757,14 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I checkProposedApiEnabled(extension); return extHostTunnelService.getTunnels(); }, + onDidChangeTunnels: (listener, thisArg?, disposables?) => { + checkProposedApiEnabled(extension); + return extHostTunnelService.onDidChangeTunnels(listener, thisArg, disposables); + + }, onDidTunnelsChange: (listener, thisArg?, disposables?) => { checkProposedApiEnabled(extension); - return extHostTunnelService.onDidTunnelsChange(listener, thisArg, disposables); + return extHostTunnelService.onDidChangeTunnels(listener, thisArg, disposables); }, registerTimelineProvider: (scheme: string, provider: vscode.TimelineProvider) => { diff --git a/src/vs/workbench/api/common/extHostTunnelService.ts b/src/vs/workbench/api/common/extHostTunnelService.ts index b81fc443758..98436355eb8 100644 --- a/src/vs/workbench/api/common/extHostTunnelService.ts +++ b/src/vs/workbench/api/common/extHostTunnelService.ts @@ -33,7 +33,7 @@ export interface IExtHostTunnelService extends ExtHostTunnelServiceShape { readonly _serviceBrand: undefined; openTunnel(forward: TunnelOptions): Promise; getTunnels(): Promise; - onDidTunnelsChange: vscode.Event; + onDidChangeTunnels: vscode.Event; setTunnelExtensionFunctions(provider: vscode.RemoteAuthorityResolver | undefined): Promise; } @@ -41,7 +41,7 @@ export const IExtHostTunnelService = createDecorator('IEx export class ExtHostTunnelService implements IExtHostTunnelService { _serviceBrand: undefined; - onDidTunnelsChange: vscode.Event = (new Emitter()).event; + onDidChangeTunnels: vscode.Event = (new Emitter()).event; async openTunnel(forward: TunnelOptions): Promise { return undefined; diff --git a/src/vs/workbench/api/node/extHostTunnelService.ts b/src/vs/workbench/api/node/extHostTunnelService.ts index 8930d91e856..4138fd2192c 100644 --- a/src/vs/workbench/api/node/extHostTunnelService.ts +++ b/src/vs/workbench/api/node/extHostTunnelService.ts @@ -39,8 +39,8 @@ export class ExtHostTunnelService extends Disposable implements IExtHostTunnelSe private _forwardPortProvider: ((tunnelOptions: TunnelOptions) => Thenable | undefined) | undefined; private _showCandidatePort: (host: string, port: number, detail: string) => Thenable = () => { return Promise.resolve(true); }; private _extensionTunnels: Map> = new Map(); - private _onDidTunnelsChange: Emitter = new Emitter(); - onDidTunnelsChange: vscode.Event = this._onDidTunnelsChange.event; + private _onDidChangeTunnels: Emitter = new Emitter(); + onDidChangeTunnels: vscode.Event = this._onDidChangeTunnels.event; constructor( @IExtHostRpcService extHostRpc: IExtHostRpcService, @@ -107,7 +107,7 @@ export class ExtHostTunnelService extends Disposable implements IExtHostTunnelSe } async $onDidTunnelsChange(): Promise { - this._onDidTunnelsChange.fire(); + this._onDidChangeTunnels.fire(); } $forwardPort(tunnelOptions: TunnelOptions): Promise | undefined {