Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-25 19:18:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix terminal-suggest completions showing up in Python REPLs

Browse Source 
Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2025-08-05 22:16:12 +00:00
parent d56fdd2279
commit 790b11d056
2 changed files with 24 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
extensions/terminal-suggest/src/test/terminalSuggestMain.test.ts
View File

@@ -6,7 +6,7 @@
import { deepStrictEqual, strictEqual } from 'assert';
import 'mocha';
import { basename } from 'path';
import { asArray, getCompletionItemsFromSpecs, getCurrentCommandAndArgs } from '../terminalSuggestMain';
import { asArray, getCompletionItemsFromSpecs, getCurrentCommandAndArgs, getTerminalShellType, TerminalShellType } from '../terminalSuggestMain';
import { getTokenType } from '../tokens';
import { cdTestSuiteSpec as cdTestSuite } from './completions/cd.test';
import { codeSpecOptionsAndSubcommands, codeTestSuite, codeTunnelTestSuite } from './completions/code.test';
@@ -149,3 +149,23 @@ class MockFigExecuteExternals implements IFigExecuteExternals {
}
}
suite('Shell Type Filtering', () => {
test('getTerminalShellType should return appropriate shell types for supported shells', () => {
strictEqual(getTerminalShellType('bash'), TerminalShellType.Bash);
strictEqual(getTerminalShellType('zsh'), TerminalShellType.Zsh);
strictEqual(getTerminalShellType('fish'), TerminalShellType.Fish);
strictEqual(getTerminalShellType('pwsh'), TerminalShellType.PowerShell);
strictEqual(getTerminalShellType('gitbash'), TerminalShellType.GitBash);
});
test('getTerminalShellType should return undefined for Python REPLs', () => {
strictEqual(getTerminalShellType('python'), undefined, 'Python REPLs should not receive terminal-suggest completions');
});
test('getTerminalShellType should return undefined for unsupported shells', () => {
strictEqual(getTerminalShellType('unsupported'), undefined);
strictEqual(getTerminalShellType(undefined), undefined);
strictEqual(getTerminalShellType(''), undefined);
});
});