Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-20 16:49:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

Disable macOS broker support due to blocking MSAL bug (#264954)

Browse Source 
Sigh... Unfortunately, MSAL seems to fail for clients that don't have managed machines that have opted in to the broker... I have opened a blocking issue on them internally.

At least, when they fix it, it would just be a matter of updating the package version and the conditional here.
This commit is contained in:
Tyler James Leonhardt
2025-09-03 07:30:49 -10:00
committed by GitHub
parent 5ffb74ec0a
commit 7a4d034fc5
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
extensions/microsoft-authentication/src/node/cachedPublicClientApplication.ts
View File

@@ -51,15 +51,17 @@ export class CachedPublicClientApplication implements ICachedPublicClientApplica
const loggerOptions = new MsalLoggerOptions(_logger, telemetryReporter);
let broker: BrokerOptions | undefined;
if (workspace.getConfiguration('microsoft-authentication').get<'msal' | 'msal-no-broker'>('implementation') !== 'msal-no-broker') {
if (process.platform !== 'win32') {
this._logger.info(`[${this._clientId}] Native Broker is only available on Windows`);
} else if (workspace.getConfiguration('microsoft-authentication').get<'msal' | 'msal-no-broker'>('implementation') === 'msal-no-broker') {
this._logger.info(`[${this._clientId}] Native Broker disabled via settings`);
} else {
const nativeBrokerPlugin = new NativeBrokerPlugin();
this.isBrokerAvailable = nativeBrokerPlugin.isBrokerAvailable;
this._logger.info(`[${this._clientId}] Native Broker enabled: ${this.isBrokerAvailable}`);
if (this.isBrokerAvailable) {
broker = { nativeBrokerPlugin };
}
} else {
this._logger.info(`[${this._clientId}] Native Broker disabled via settings`);
}
this._pca = new PublicClientApplication({
auth: { clientId: _clientId },