From 7bd499af9bc2b210b1faa499f9af5ed7cdf1af48 Mon Sep 17 00:00:00 2001
From: Daniel Imms <tyriar@tyriar.com>
Date: Thu, 1 Sep 2016 14:00:10 -0700
Subject: [PATCH] Revert "Use a config interface for terminal creation in API"

We're sticking with simple for now, an overload can be used if a config object
is necessary later.

This reverts commit 873b3d0b3803b6f3555599b250c7f256ec68d36e.
---
 src/vs/vscode.d.ts                                 | 14 ++------------
 src/vs/workbench/api/node/extHost.api.impl.ts      |  4 ++--
 .../workbench/api/node/extHostTerminalService.ts   |  4 ++--
 3 files changed, 6 insertions(+), 16 deletions(-)

diff --git a/src/vs/vscode.d.ts b/src/vs/vscode.d.ts
index 2e1b0ece5fa..d230fff49f4 100644
--- a/src/vs/vscode.d.ts
+++ b/src/vs/vscode.d.ts
@@ -3029,16 +3029,6 @@ declare namespace vscode {
 		dispose(): void;
 	}
 
-	/**
-	 * A configuration describing a terminal within the integrated terminal.
-	 */
-	export interface TerminalConfiguration {
-		/**
-		 * A human-readable string which will be used to represent the terminal in the UI.
-		 */
-		name?: string
-	}
-
 	/**
 	 * Represents an extension.
 	 *
@@ -3501,10 +3491,10 @@ declare namespace vscode {
 		/**
 		 * Creates a [Terminal](#Terminal).
 		 *
-		 * @param configuration A configuration object for the terminal.
+		 * @param name Optional human-readable string which will be used to represent the terminal in the UI.
 		 * @return A new Terminal.
 		 */
-		export function createTerminal(configuration: TerminalConfiguration): Terminal;
+		export function createTerminal(name?: string): Terminal;
 	}
 
 	/**
diff --git a/src/vs/workbench/api/node/extHost.api.impl.ts b/src/vs/workbench/api/node/extHost.api.impl.ts
index 3faf6fa5882..f4c1b144ae0 100644
--- a/src/vs/workbench/api/node/extHost.api.impl.ts
+++ b/src/vs/workbench/api/node/extHost.api.impl.ts
@@ -258,8 +258,8 @@ export class ExtHostAPIImplementation {
 			createOutputChannel(name: string): vscode.OutputChannel {
 				return extHostOutputService.createOutputChannel(name);
 			},
-			createTerminal(configuration: vscode.TerminalConfiguration): vscode.Terminal {
-				return extHostTerminalService.createTerminal(configuration);
+			createTerminal(name?: string): vscode.Terminal {
+				return extHostTerminalService.createTerminal(name);
 			}
 		};
 
diff --git a/src/vs/workbench/api/node/extHostTerminalService.ts b/src/vs/workbench/api/node/extHostTerminalService.ts
index 635276bd07c..e1dead17d1b 100644
--- a/src/vs/workbench/api/node/extHostTerminalService.ts
+++ b/src/vs/workbench/api/node/extHostTerminalService.ts
@@ -85,8 +85,8 @@ export class ExtHostTerminalService {
 		this._proxy = threadService.get(MainContext.MainThreadTerminalService);
 	}
 
-	public createTerminal(configuration: vscode.TerminalConfiguration): vscode.Terminal {
-		return new ExtHostTerminal(this._proxy, -1, configuration.name);
+	public createTerminal(name?: string): vscode.Terminal {
+		return new ExtHostTerminal(this._proxy, -1, name);
 	}
 }