Log errors encountered during deactivate

This commit is contained in:
Alex Dima
2021-05-18 13:24:28 +02:00
parent e4159c8f89
commit 7c07550dbc
2 changed files with 4 additions and 4 deletions

View File

@@ -292,19 +292,19 @@ export abstract class AbstractExtHostExtensionService extends Disposable impleme
try {
if (typeof extension.module.deactivate === 'function') {
result = Promise.resolve(extension.module.deactivate()).then(undefined, (err) => {
// TODO: Do something with err if this is not the shutdown case
this._logService.error(err);
return Promise.resolve(undefined);
});
}
} catch (err) {
// TODO: Do something with err if this is not the shutdown case
this._logService.error(err);
}
// clean up subscriptions
try {
dispose(extension.subscriptions);
} catch (err) {
// TODO: Do something with err if this is not the shutdown case
this._logService.error(err);
}
return result;