From 7ccfdd3a003727c76bca44eeb393e2d9fa5d06ee Mon Sep 17 00:00:00 2001 From: Joao Moreno Date: Fri, 8 Mar 2019 10:15:28 +0100 Subject: [PATCH] do not sanitize remote url --- extensions/git/src/commands.ts | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/extensions/git/src/commands.ts b/extensions/git/src/commands.ts index 7dbd7d0586d..76d8ce8dbcc 100755 --- a/extensions/git/src/commands.ts +++ b/extensions/git/src/commands.ts @@ -1809,12 +1809,7 @@ export class CommandCenter { const sanitize = (name: string) => { name = name.trim(); - - if (!name) { - return name; - } - - return name.replace(/^\.|\/\.|\.\.|~|\^|:|\/$|\.lock$|\.lock\/|\\|\*|\s|^\s*$|\.$|\[|\]$/g, '-'); + return name && name.replace(/^\.|\/\.|\.\.|~|\^|:|\/$|\.lock$|\.lock\/|\\|\*|\s|^\s*$|\.$|\[|\]$/g, '-'); }; const resultName = await window.showInputBox({ @@ -1836,18 +1831,16 @@ export class CommandCenter { } if (remotes.find(r => r.name === name)) { - window.showErrorMessage(localize('remote already exists', 'Remote by name \"{0}\" already exists.', name)); + window.showErrorMessage(localize('remote already exists', "Remote '{0}' already exists.", name)); return; } - const resultUrl = await window.showInputBox({ + const url = await window.showInputBox({ placeHolder: localize('remote url', "Remote URL"), prompt: localize('provide remote URL', "Enter URL for remote \"{0}\"", name), ignoreFocusOut: true }); - const url = sanitize(resultUrl || ''); - if (!url) { return; }