From 7ce2824069c035fa63f31e7d7b3c2fc73eefdce7 Mon Sep 17 00:00:00 2001 From: Rob Lourens Date: Tue, 23 Jan 2018 15:39:50 -0800 Subject: [PATCH] Settings search - fix JSON-encoded default values from remote search --- .../parts/preferences/electron-browser/preferencesSearch.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/parts/preferences/electron-browser/preferencesSearch.ts b/src/vs/workbench/parts/preferences/electron-browser/preferencesSearch.ts index 7614813e29fe..3366eafe38d7 100644 --- a/src/vs/workbench/parts/preferences/electron-browser/preferencesSearch.ts +++ b/src/vs/workbench/parts/preferences/electron-browser/preferencesSearch.ts @@ -215,6 +215,9 @@ class RemoteSearchProvider implements ISearchProvider { const packageId = r['packageid']; const id = getSettingKey(key, packageId); + const value = r['value']; + const defaultValue = value ? JSON.parse(value) : value; + const packageName = r['packagename']; let extensionName: string; let extensionPublisher: string; @@ -225,7 +228,7 @@ class RemoteSearchProvider implements ISearchProvider { return { key, id, - defaultValue: r['value'], + defaultValue, score: r['@search.score'], description: JSON.parse(r['details']), packageId,