Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-21 09:08:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

tweak vscode.open command and its test, https://github.com/microsoft/vscode/pull/141944

Browse Source
This commit is contained in:
Johannes Rieken
2022-02-01 18:35:02 +01:00
parent 09c2e177ea
commit 7d1f0fda8b
3 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
extensions/vscode-api-tests/src/singlefolder-tests/commands.test.ts
View File

@@ -119,9 +119,6 @@ suite('vscode API - commands', () => {
await commands.executeCommand('vscode.open', uri, ViewColumn.One);
assert.strictEqual(window.activeTextEditor?.viewColumn, ViewColumn.One);
await commands.executeCommand('vscode.open', uri.toString(), ViewColumn.Two); // call with string instead of URI
assert.strictEqual(window.activeTextEditor?.viewColumn, ViewColumn.Two);
let e1: Error | undefined = undefined;
try {
await commands.executeCommand('vscode.open');
@@ -137,6 +134,17 @@ suite('vscode API - commands', () => {
e2 = error;
}
assert.ok(e2);
// we support strings but only http/https. those we cannot test but we can
// enforce that other schemes are treated strict
try {
await commands.executeCommand('vscode.open', 'file:///some/path/not/http');
assert.fail('expecting exception');
} catch {
assert.ok(true);
}
});
test('api-command: vscode.open with untitled supports associated resource (#138925)', async function () {