diff --git a/src/typings/electron.d.ts b/src/typings/electron.d.ts index e68adb47652..23565cc3128 100644 --- a/src/typings/electron.d.ts +++ b/src/typings/electron.d.ts @@ -1238,6 +1238,7 @@ declare module GitHubElectron { */ detail?: string; icon?: NativeImage; + noLink?: boolean; } } @@ -1823,13 +1824,13 @@ declare module GitHubElectron { } } -// interface Window { -// /** -// * Creates a new window. -// * @returns An instance of BrowserWindowProxy class. -// */ -// open(url: string, frameName?: string, features?: string): GitHubElectron.BrowserWindowProxy; -// } +interface Window { + /** + * Creates a new window. + * @returns An instance of BrowserWindowProxy class. + */ + open(url: string, frameName?: string, features?: string): GitHubElectron.BrowserWindowProxy; +} interface File { /** diff --git a/src/vs/workbench/electron-browser/window.ts b/src/vs/workbench/electron-browser/window.ts index ad316d52c13..7a9e8962291 100644 --- a/src/vs/workbench/electron-browser/window.ts +++ b/src/vs/workbench/electron-browser/window.ts @@ -126,10 +126,10 @@ export class ElectronWindow { }); // Handle window.open() calls - window.open = function(url: string, target: string, features: string, replace: boolean) { + (window).open = function(url: string, target: string, features: string, replace: boolean) { shell.openExternal(url); - return null; + return null; }; } diff --git a/src/vs/workbench/electron-main/main.ts b/src/vs/workbench/electron-main/main.ts index 4c3654bce33..b9be297bae6 100644 --- a/src/vs/workbench/electron-main/main.ts +++ b/src/vs/workbench/electron-main/main.ts @@ -5,9 +5,8 @@ 'use strict'; -import {app, shell} from 'electron'; +import {app, shell, dialog} from 'electron'; import fs = require('fs'); -import dialog = require('dialog'); import nls = require('vs/nls'); import {assign} from 'vs/base/common/objects'; import platform = require('vs/base/common/platform');