Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 01:58:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add telemetry on how often server crashes are potentially due to TS service plugins (#223551)

Browse Source 
Add telemetry on how often server crashes are potentially due to TS server plugins

Simple flag which tracks if plugins are enabled/disabled
This commit is contained in:
Matt Bierner
2024-07-24 15:20:38 -07:00
committed by GitHub
parent 4c0c00f172
commit 7d59bab235
1 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
extensions/typescript-language-features/src/typescriptServiceClient.ts
View File

@@ -424,6 +424,7 @@ export default class TypeScriptServiceClient extends Disposable implements IType
this.serverState = new ServerState.Running(handle, apiVersion, undefined, true);
this.lastStart = Date.now();
const hasGlobalPlugins = this.pluginManager.plugins.length > 0;
/* __GDPR__
"tsserver.spawned" : {
"owner": "mjbvz",
@@ -431,12 +432,14 @@ export default class TypeScriptServiceClient extends Disposable implements IType
"${TypeScriptCommonProperties}"
],
"localTypeScriptVersion": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
"typeScriptVersionSource": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
"typeScriptVersionSource": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
"hasGlobalPlugins": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
}
*/
this.logTelemetry('tsserver.spawned', {
localTypeScriptVersion: this.versionProvider.localVersion ? this.versionProvider.localVersion.displayName : '',
typeScriptVersionSource: version.source,
hasGlobalPlugins,
});
handle.onError((err: Error) => {
@@ -460,10 +463,11 @@ export default class TypeScriptServiceClient extends Disposable implements IType
"owner": "mjbvz",
"${include}": [
"${TypeScriptCommonProperties}"
]
],
"hasGlobalPlugins": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
}
*/
this.logTelemetry('tsserver.error');
this.logTelemetry('tsserver.error', { hasGlobalPlugins });
this.serviceExited(false, apiVersion);
});
@@ -476,14 +480,19 @@ export default class TypeScriptServiceClient extends Disposable implements IType
/* __GDPR__
"tsserver.exitWithCode" : {
"owner": "mjbvz",
"code" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
"signal" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
"${include}": [
"${TypeScriptCommonProperties}"
]
],
"code" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
"signal" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
"hasGlobalPlugins": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
}
*/
this.logTelemetry('tsserver.exitWithCode', { code: code ?? undefined, signal: signal ?? undefined });
this.logTelemetry('tsserver.exitWithCode', {
code: code ?? undefined,
signal: signal ?? undefined,
hasGlobalPlugins,
});
if (this.token !== mytoken) {
// this is coming from an old process