Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-26 11:38:51 +01:00
Code Issues Packages Projects Releases Wiki Activity

Update logging & delete dead code (#234458)

Browse Source 
* Update logging values so the logs aren't so noisy
* Delete a bunch of dead async code
This commit is contained in:
Tyler James Leonhardt
2024-11-22 16:17:07 -08:00
committed by GitHub
parent b64f656c21
commit 7ddb65bac8
4 changed files with 16 additions and 325 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
extensions/microsoft-authentication/src/common/loggerOptions.ts
View File

@@ -17,9 +17,13 @@ export class MsalLoggerOptions {
loggerCallback(level: MsalLogLevel, message: string, containsPii: boolean): void {
if (containsPii) {
// TODO: Should we still log the message if it contains PII? It's just going to
// an output channel that doesn't leave the machine.
this._output.debug('Skipped logging message because it may contain PII');
return;
}
// Log to output channel one level lower than the MSAL log level
switch (level) {
case MsalLogLevel.Error:
this._output.error(message);
@@ -28,16 +32,16 @@ export class MsalLoggerOptions {
this._output.warn(message);
return;
case MsalLogLevel.Info:
this._output.info(message);
return;
case MsalLogLevel.Verbose:
this._output.debug(message);
return;
case MsalLogLevel.Trace:
case MsalLogLevel.Verbose:
this._output.trace(message);
return;
case MsalLogLevel.Trace:
// Do not log trace messages
return;
default:
this._output.info(message);
this._output.debug(message);
return;
}
}