Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-25 19:18:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Update logging & delete dead code (#234458)

Browse Source 
* Update logging values so the logs aren't so noisy
* Delete a bunch of dead async code
This commit is contained in:
Tyler James Leonhardt
2024-11-22 16:17:07 -08:00
committed by GitHub
parent b64f656c21
commit 7ddb65bac8
4 changed files with 16 additions and 325 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
extensions/microsoft-authentication/src/extension.ts
View File

@@ -15,26 +15,26 @@ function shouldUseMsal(expService: IExperimentationService): boolean {
// First check if there is a setting value to allow user to override the default
const inspect = workspace.getConfiguration('microsoft-authentication').inspect<'msal' | 'classic'>('implementation');
if (inspect?.workspaceFolderValue !== undefined) {
Logger.debug(`Acquired MSAL enablement value from 'workspaceFolderValue'. Value: ${inspect.workspaceFolderValue}`);
Logger.info(`Acquired MSAL enablement value from 'workspaceFolderValue'. Value: ${inspect.workspaceFolderValue}`);
return inspect.workspaceFolderValue === 'msal';
}
if (inspect?.workspaceValue !== undefined) {
Logger.debug(`Acquired MSAL enablement value from 'workspaceValue'. Value: ${inspect.workspaceValue}`);
Logger.info(`Acquired MSAL enablement value from 'workspaceValue'. Value: ${inspect.workspaceValue}`);
return inspect.workspaceValue === 'msal';
}
if (inspect?.globalValue !== undefined) {
Logger.debug(`Acquired MSAL enablement value from 'globalValue'. Value: ${inspect.globalValue}`);
Logger.info(`Acquired MSAL enablement value from 'globalValue'. Value: ${inspect.globalValue}`);
return inspect.globalValue === 'msal';
}
// Then check if the experiment value
const expValue = expService.getTreatmentVariable<boolean>('vscode', 'microsoft.useMsal');
if (expValue !== undefined) {
Logger.debug(`Acquired MSAL enablement value from 'exp'. Value: ${expValue}`);
Logger.info(`Acquired MSAL enablement value from 'exp'. Value: ${expValue}`);
return expValue;
}
Logger.debug('Acquired MSAL enablement value from default. Value: false');
Logger.info('Acquired MSAL enablement value from default. Value: true');
// If no setting or experiment value is found, default to false
return true;
}