Only try tunneling openExternal when we actually need to

This commit is contained in:
Matt Bierner
2019-04-15 15:26:18 -07:00
parent 4c3694fd2d
commit 80a2614355
5 changed files with 14 additions and 10 deletions

View File

@@ -253,7 +253,7 @@ export function createApiFactory(
return extHostClipboard;
},
openExternal(uri: URI) {
return extHostWindow.openUri(uri);
return extHostWindow.openUri(uri, { allowTunneling: !!initData.remoteAuthority });
}
});

View File

@@ -202,9 +202,9 @@ export class OpenNodeModuleFactory implements INodeModuleFactory {
return this.callOriginal(target, options);
}
if (uri.scheme === 'http' || uri.scheme === 'https') {
return mainThreadWindow.$openUri(uri);
return mainThreadWindow.$openUri(uri, { allowTunneling: true });
} else if (uri.scheme === 'mailto') {
return mainThreadWindow.$openUri(uri);
return mainThreadWindow.$openUri(uri, {});
}
return this.callOriginal(target, options);
};