From 810f7a00a18aef7c0af592d53955b4e20d28a810 Mon Sep 17 00:00:00 2001 From: Connor Peet Date: Fri, 13 Jun 2025 09:15:00 -0700 Subject: [PATCH] mcp: fix test error in McpStdioStateHandler (#251401) --- src/vs/workbench/contrib/mcp/node/mcpStdioStateHandler.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/contrib/mcp/node/mcpStdioStateHandler.ts b/src/vs/workbench/contrib/mcp/node/mcpStdioStateHandler.ts index fba931a0280..3166cdea8c5 100644 --- a/src/vs/workbench/contrib/mcp/node/mcpStdioStateHandler.ts +++ b/src/vs/workbench/contrib/mcp/node/mcpStdioStateHandler.ts @@ -65,7 +65,9 @@ export class McpStdioStateHandler implements IDisposable { if (this._child.pid) { if (!isWindows) { - await killTree(this._child.pid, false); + await killTree(this._child.pid, false).catch(() => { + this._child.kill('SIGTERM'); + }); } } else { this._child.kill('SIGTERM'); @@ -76,7 +78,9 @@ export class McpStdioStateHandler implements IDisposable { this._procState = McpProcessState.KilledForceful; if (this._child.pid) { - await killTree(this._child.pid, true); + await killTree(this._child.pid, true).catch(() => { + this._child.kill('SIGKILL'); + }); } else { this._child.kill(); }