Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 01:58:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

💄 we can guarantee notebook events if command is not notebook related.

Browse Source
This commit is contained in:
rebornix
2020-06-08 11:26:48 -07:00
parent 2da43c7d93
commit 83286288a7
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
extensions/vscode-notebook-tests/src/notebook.test.ts
View File

@@ -217,7 +217,7 @@ suite('API tests', () => {
await vscode.commands.executeCommand('workbench.action.closeAllEditors');
});
test.skip('notebook editor active/visible', async function () {
test('notebook editor active/visible', async function () {
const resource = vscode.Uri.file(join(vscode.workspace.rootPath || '', './first.vsctestnb'));
await vscode.commands.executeCommand('vscode.openWith', resource, 'notebookCoreTest');
const firstEditor = vscode.notebook.activeNotebookEditor;
@@ -232,15 +232,18 @@ suite('API tests', () => {
assert.equal(vscode.notebook.visibleNotebookEditors.length, 2);
const untitledEditorChange = getEventOncePromise(vscode.notebook.onDidChangeActiveNotebookEditor);
await vscode.commands.executeCommand('workbench.action.files.newUntitledFile');
// TODO@rebornix, this is not safe, we might need to listen to visible editor change event.
await untitledEditorChange;
assert.equal(firstEditor?.visible, true);
assert.equal(firstEditor?.active, false);
assert.equal(secondEditor?.visible, false);
assert.equal(secondEditor?.active, false);
assert.equal(vscode.notebook.visibleNotebookEditors.length, 1);
const activeEditorClose = getEventOncePromise(vscode.notebook.onDidChangeActiveNotebookEditor);
await vscode.commands.executeCommand('workbench.action.closeActiveEditor');
await activeEditorClose;
assert.equal(secondEditor?.active, true);
assert.equal(secondEditor?.visible, true);
assert.equal(vscode.notebook.visibleNotebookEditors.length, 2);