Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-18 07:47:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

chat: fix createModelReference leak in ResolveSymbolsContextAction (#306068)

Browse Source 
Improve error handling in ResolveSymbolsContextAction by ensuring model reference disposal
This commit is contained in:
Rob Lourens
2026-03-28 22:15:27 -07:00
committed by GitHub
parent 1ae3819053
commit 83700a8c46
1 changed files with 24 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingActions.ts
View File

@@ -807,6 +807,7 @@ registerAction2(class ResolveSymbolsContextAction extends EditingSessionAction {
const symbol = args[0] as Location;
const modelReference = await textModelService.createModelReference(symbol.uri);
try {
const textModel = modelReference.object.textEditorModel;
if (!textModel) {
return;
@@ -828,6 +829,9 @@ registerAction2(class ResolveSymbolsContextAction extends EditingSessionAction {
}
chatWidget.attachmentModel.addContext(...attachments);
} finally {
modelReference.dispose();
}
}
private async getReferences(position: Position, textModel: ITextModel, languageFeaturesService: ILanguageFeaturesService): Promise<Location[]> {