Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-26 03:29:00 +01:00
Code Issues Packages Projects Releases Wiki Activity

Only mark custom editor as non-dirty once save has completed successfully

Browse Source 
Fixes #101872
This commit is contained in:
Matt Bierner
2020-10-14 16:54:12 -07:00
parent 88929c7a45
commit 8397461b70
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/vs/workbench/api/browser/mainThreadCustomEditors.ts
View File

@@ -522,19 +522,22 @@ class MainThreadCustomEditorModel extends Disposable implements ICustomEditorMod
this._ongoingSave?.cancel();
this._ongoingSave = savePromise;
this.change(() => {
this._isDirtyFromContentChange = false;
this._savePoint = this._currentEditIndex;
this._fromBackup = false;
});
try {
await savePromise;
if (this._ongoingSave === savePromise) { // Make sure we are still doing the same save
this.change(() => {
this._isDirtyFromContentChange = false;
this._savePoint = this._currentEditIndex;
this._fromBackup = false;
});
}
} finally {
if (this._ongoingSave === savePromise) {
if (this._ongoingSave === savePromise) { // Make sure we are still doing the same save
this._ongoingSave = undefined;
}
}
return this._editorResource;
}