Fix some always true/false errors in codebase (#223359)

* Fix some always true/false errors in codebase

Testing out latest TS nightly that can identify when an expression is always true/false. This caught a few likely coding mistakes in our codebase

Unsure about the intent in some of these cases but I've tried my best to understand them. Pinging relevant code owners for the confusing cases

* Bump TS version

* Fix unreachable in build scripts

* Bump versions

* restore intent

* Revert package.json change

* Fixing a few new layer checker errors

These are global in node now

* Skip lib check in integration project

* One more skiplibcheck

* More skip lib

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
This commit is contained in:
Matt Bierner
2024-07-30 15:37:27 -07:00
committed by GitHub
parent ce8baddd73
commit 84607a2fe2
21 changed files with 68 additions and 28 deletions

View File

@@ -7,6 +7,7 @@
"noUnusedLocals": true,
"outDir": "out",
"sourceMap": true,
"skipLibCheck": true,
"declaration": true,
"lib": [
"esnext", // for #201187