Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-27 03:54:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix request position of the inlay hints

Browse Source 
Fixes #129134

The document may change between the request and when `ensureConfigurationForDocument` completes

I think this should fix the shifting around
This commit is contained in:
Matt Bierner
2021-07-22 17:52:59 -07:00
parent 50ac52ca92
commit 847a6d8cd0
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
extensions/typescript-language-features/src/languageFeatures/inlayHints.ts
View File

@@ -117,11 +117,11 @@ class TypeScriptInlayHintsProvider extends Disposable implements vscode.InlayHin
return [];
}
await this.fileConfigurationManager.ensureConfigurationForDocument(model, token);
const start = model.offsetAt(range.start);
const length = model.offsetAt(range.end) - start;
await this.fileConfigurationManager.ensureConfigurationForDocument(model, token);
const response = await (this.client as ExperimentalProto.IExtendedTypeScriptServiceClient).execute('provideInlayHints', { file: filepath, start, length }, token);
if (response.type !== 'response' || !response.success || !response.body) {
return [];