Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-02 14:31:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

add local resource root and cancelCells so that Kernel2 is very similar to Kernel

Browse Source
This commit is contained in:
Johannes Rieken
2021-04-07 15:12:45 +02:00
parent 9221eb9697
commit 84f3054624
5 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/vs/workbench/api/browser/mainThreadNotebookKernels.ts
View File

@@ -27,18 +27,20 @@ abstract class MainThreadKernel implements INotebookKernel2 {
isPreferred?: boolean;
supportedLanguages: string[];
hasExecutionOrder: boolean;
localResourceRoot: URI;
preloads?: URI[];
constructor(data: INotebookKernelDto2) {
this.id = data.id;
this.selector = data.selector;
this.detail = data.displayName;
this.detail = data.extensionName;
this.label = data.label;
this.description = data.description;
this.isPreferred = data.isPreferred;
this.supportedLanguages = data.supportedLanguages;
this.hasExecutionOrder = data.hasExecutionOrder ?? false;
this.preloads = data.preloads;
this.localResourceRoot = URI.revive(data.extensionLocation);
this.preloads = data.preloads && data.preloads.map(u => URI.revive(u));
}
@@ -69,6 +71,7 @@ abstract class MainThreadKernel implements INotebookKernel2 {
abstract setSelected(value: boolean): void;
abstract executeCells(cells: ICell[]): void;
abstract cancelCells(cells: ICell[]): void;
}
@extHostNamedCustomer(MainContext.MainThreadNotebookKernels)
@@ -103,6 +106,9 @@ export class MainThreadNotebookKernels implements MainThreadNotebookKernelsShape
that._commandService.executeCommand(data.executeCommand.id, cells);
}
}
cancelCells(cells: ICell[]): void {
// todo@jrieken
}
}(data);
const disposable = this._notebookKernelService.addKernel(kernel);
this._kernels.set(handle, [kernel, disposable]);