Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-28 12:33:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

cli: allow public port forwarding via tunnels (#209489)

Browse Source
This commit is contained in:
Connor Peet
2024-04-03 15:28:00 -07:00
committed by GitHub
parent 0f13661a91
commit 8558da1335
6 changed files with 28 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
cli/src/tunnels/control_server.rs
View File

@@ -10,7 +10,7 @@ use crate::options::Quality;
use crate::rpc::{MaybeSync, RpcBuilder, RpcCaller, RpcDispatcher};
use crate::self_update::SelfUpdate;
use crate::state::LauncherPaths;
use crate::tunnels::protocol::{HttpRequestParams, METHOD_CHALLENGE_ISSUE};
use crate::tunnels::protocol::{HttpRequestParams, PortPrivacy, METHOD_CHALLENGE_ISSUE};
use crate::tunnels::socket_signal::CloseReason;
use crate::update_service::{Platform, Release, TargetKind, UpdateService};
use crate::util::command::new_tokio_command;
@@ -1077,8 +1077,16 @@ async fn handle_forward(
let port_forwarding = port_forwarding
.as_ref()
.ok_or(CodeError::PortForwardingNotAvailable)?;
info!(log, "Forwarding port {}", params.port);
let uri = port_forwarding.forward(params.port).await?;
info!(
log,
"Forwarding port {} (public={})", params.port, params.public
);
let privacy = match params.public {
true => PortPrivacy::Public,
false => PortPrivacy::Private,
};
let uri = port_forwarding.forward(params.port, privacy).await?;
Ok(ForwardResult { uri })
}